file.c: fix uninitialized mutex in MPI_File handle #12416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
approved these changes
Mar 19, 2024
jsquyres
force-pushed
the
pr/mpi-file-mutex-fix
branch
from
4417a1d
to
564068c
Compare
|
@edgargabriel Found another issue; I fixed and re-pushed. @bosilca saw the fix in Slack and approved it there (so even though my push is after his github approval, he still approved 👍). |
bosilca
reviewed
Mar 19, 2024
We were initializing the mutex in file_open, but that didn't handle MPI_FILE_NULL. So we move it to the constructor, and therefore it's always initialized for all file handles -- even MPI_FILE_NULL. Signed-off-by: George Bosilca <[email protected]> Signed-off-by: Jeff Squyres <[email protected]>
|
@bosilca @edgargabriel Please re-review. |
jsquyres
force-pushed
the
pr/mpi-file-mutex-fix
branch
from
564068c
to
2118615
Compare
bosilca
approved these changes
Mar 20, 2024
|
The |
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were initializing the mutex in file_open, but that didn't handle MPI_FILE_NULL. So we move it to the constructor, and therefore it's always initialized for all file handles -- even MPI_FILE_NULL.
Thanks to mpi4py test suite for finding this one. 👍