Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collective framework for bigcount #12478

Closed
wants to merge 1 commit into from

Conversation

jtronge
Copy link
Contributor

@jtronge jtronge commented Apr 19, 2024

This should update the collective framework to use size_t/ptrdiff_t for counts/displacements. There are a few places that will need to be changed once other components are updated for bigcount (such as the opal/ompi datatype code) and these are indicated with TODO:BIGCOUNT comments.

Copy link
Member

@bosilca bosilca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right approach, at least not for all the functions that take arrays of sizes and displacements. Indeed, this approach will force us to allocate/deallocate memory in the current API for in C and in Fortran, leading to serious performance implications.

Update the collective framework and dependent code to use
size_t/ptrdiff_t for counts/displacements when necessary.
Several places include comments with TODO:BIGCOUNT for changes that rely
on updates to other libraries, such as the ompi/opal datatype code.

Co-authored-by: Howard Pritchard <[email protected]>
Signed-off-by: Jake Tronge <[email protected]>
@hppritcha
Copy link
Member

related to #12336

hppritcha pushed a commit to hppritcha/ompi that referenced this pull request May 9, 2024
This commit adds only those functions which make use of C integer promotion.
So none of the 'v,w' and reduce_scatter related methods are added in this PR.

Related to open-mpi#12336
Pieces of open-mpi#12478 were taken out to make this PR.

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha pushed a commit to hppritcha/ompi that referenced this pull request May 20, 2024
This commit adds only those functions which make use of C integer promotion.
So none of the 'v,w' and reduce_scatter related methods are added in this PR.

Related to open-mpi#12336
Pieces of open-mpi#12478 were taken out to make this PR.

Signed-off-by: Howard Pritchard <[email protected]>
@jtronge
Copy link
Contributor Author

jtronge commented Jun 14, 2024

Replaced by PRs #12539 and #12621.

@jtronge jtronge closed this Jun 14, 2024
hpcraink pushed a commit to hpcraink/ompi that referenced this pull request Jul 4, 2024
This commit adds only those functions which make use of C integer promotion.
So none of the 'v,w' and reduce_scatter related methods are added in this PR.

Related to open-mpi#12336
Pieces of open-mpi#12478 were taken out to make this PR.

Signed-off-by: Howard Pritchard <[email protected]>
eliranmaman pushed a commit to ICLDisco/ompi that referenced this pull request Jul 8, 2024
This commit adds only those functions which make use of C integer promotion.
So none of the 'v,w' and reduce_scatter related methods are added in this PR.

Related to open-mpi#12336
Pieces of open-mpi#12478 were taken out to make this PR.

Signed-off-by: Howard Pritchard <[email protected]>
mdosanjh pushed a commit to mdosanjh/ompi that referenced this pull request Aug 1, 2024
This commit adds only those functions which make use of C integer promotion.
So none of the 'v,w' and reduce_scatter related methods are added in this PR.

Related to open-mpi#12336
Pieces of open-mpi#12478 were taken out to make this PR.

Signed-off-by: Howard Pritchard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants