Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate blocking unblocking collectives in UCC #12616

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

bosilca
Copy link
Member

@bosilca bosilca commented Jun 13, 2024

Provide a hint to UCC collective init to know it is dealing with a blocking collective.

@bosilca bosilca added this to the v5.0.4 milestone Jun 13, 2024
@bosilca bosilca requested a review from janjust June 28, 2024 00:24
Copy link
Contributor

@Sergei-Lebedev Sergei-Lebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be easier to just modify COLL_UCC_REQ_INIT macro e.g.

#define COLL_UCC_REQ_INIT(_coll_req, _req, _coll, _module) do{          \
        if (_coll_req) {                                                \
            _coll.mask   |= UCC_COLL_ARGS_FIELD_CB;                     \
            _coll.cb.cb   = mca_coll_ucc_completion;                    \
            _coll.cb.data = (void*)_coll_req;                           \
        } else {                                                        \
            _coll.mask  |= UCC_COLL_ARGS_FIELD_FLAGS;                   \
            _coll.flags |= UCC_COLL_ARGS_HINT_OPTIMIZE_LATENCY;         \
        }                                                               \
        COLL_UCC_CHECK(ucc_collective_init(&_coll, _req,                \
                                           _module->ucc_team));         \
        if (_coll_req) {                                                \
            _coll_req->ucc_req = *(_req);                               \
        }                                                               \
    } while(0)

So you don't need to add extra arg and repeat same code in every collective

@bosilca bosilca force-pushed the nvidia/ucc/blocking branch 3 times, most recently from 7daa754 to 97e4519 Compare July 1, 2024 19:10
Signed-off-by: Geoffroy Vallee <[email protected]>
Signed-off-by: George Bosilca <[email protected]>
@janjust
Copy link
Contributor

janjust commented Jul 3, 2024

@bosilca when merged - can we get a v5.0.x cherry-pick?

@bosilca bosilca merged commit ff12b69 into open-mpi:main Jul 3, 2024
13 checks passed
@bosilca bosilca deleted the nvidia/ucc/blocking branch July 3, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants