Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve documentation for the coll tuned component #12642

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

burlen
Copy link

@burlen burlen commented Jun 26, 2024

Adds documentation to the user guide for the coll tuned component. It's not intended to be comprehensive but rather summarize the key information needed to effectively use the tuning features.

resolves #12641

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the 1 nit, this is actually fantastic!

Could you make that minor update?

Tuning Collectives
==================

Open MPI's `coll` framework provides a number of components implementing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the rest of the docs, I think the convention we've used is

``coll``

i.e., double quotes so that coll shows up in fixed-width font, not italics.

Same with the coll component names, below. Like this:

Screenshot 2024-06-28 at 3 36 21 PM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixed that

@jsquyres jsquyres merged commit ca33c7f into open-mpi:main Jul 10, 2024
13 checks passed
@jsquyres
Copy link
Member

Thank you @burlen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation of the coll tuned component
3 participants