fcoll/vulcan accelerator support #12678
Open
+268
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
changed the title
edgargabriel
force-pushed
the
topic/fcoll-vulcan-accelerator-support
branch
from
74a3029
to
8b24867
Compare
edgargabriel
force-pushed
the
topic/fcoll-vulcan-accelerator-support
branch
from
d945c11
to
0beeef3
Compare
If the user user input buffers are GPU device memory, use also GPU device memory for the aggregation step. This will allow the data transfer to occur between GPU buffers, and hence take advantage of the much higher GPU-GPU interconnects (e.g. XGMI, NVLINK, etc.). The downside of this approach is that we cannot call directly into the fbtl ipwritev routine, but have to go through the common_ompio_file_iwrite_pregen routine, which performs the necessary segmenting and staging through the host memory. Signed-off-by: Edgar Gabriel <[email protected]>
add support for using accelerator buffers in the aggregation step of the read_all operation. This is in common/ompio instead of the fcoll component, since all fcoll components (except individual) use at the momment the default implementation, which has been moved to common/ompio a while back to avoid code duplication. Signed-off-by: Edgar Gabriel <[email protected]>
performance measurements indicate that in most cases using a CPU host buffer for data aggregation will lead to better performance than using a GPU buffer. So turn the feature off by default. Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel
force-pushed
the
topic/fcoll-vulcan-accelerator-support
branch
from
0beeef3
to
f8bc3fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.