portals4: update the coll-portals4 component to be Big Count compliant #12714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Kordenbrock <[email protected]>
Signed-off-by: Todd Kordenbrock <[email protected]>
mdosanjh
approved these changes
Jul 30, 2024
|
@tkordenbrock @mdosanjh Did you want to merge this PR, or are you intentionally waiting for some reason? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Big Count implementation bumped the coll base struct version to 3.0.0. This PR updates the coll-portals4 component to use coll base 3.0.0, updates function signatures to be Big Count compliant and fixes some compiler warnings.