Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix explanation of in-place option for MPI_Allgather(v) #12729

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

jedbrown
Copy link
Contributor

@jedbrown jedbrown commented Aug 1, 2024

These man pages (for MPI_Allgather and MPI_Allgatherv when using MPI_IN_PLACE) were wrong (intended to call MPI_Gather(v)). The example is a bit confusing because recvbuf is modified in a loop of repeat calls, but I think the loop is still correct because the subset of recvbuf that acts as send area when using MPI_IN_PLACE should be invariant. I don't know if you want to keep this explanation; it certainly can't be used to explain sibling collectives that support MPI_IN_PLACE.

(Apologies for the incorrect explanation prior to edit.)

Copy link

github-actions bot commented Aug 1, 2024

Hello! The Git Commit Checker CI bot found a few problems with this PR:

f40711c: WIP: fix explanation of in-place option

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@jedbrown jedbrown force-pushed the jed/fix-allgather-in-place-docs branch from f40711c to c80a18d Compare August 1, 2024 19:28
Copy link

github-actions bot commented Aug 1, 2024

Hello! The Git Commit Checker CI bot found a few problems with this PR:

c80a18d: doc: fix explanation of in-place option for MPI_Al...

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@jedbrown jedbrown changed the title WIP: fix explanation of in-place option fix explanation of in-place option for MPI_Allgather(v) Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Hello! The Git Commit Checker CI bot found a few problems with this PR:

c80a18d: doc: fix explanation of in-place option for MPI_Al...

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@jedbrown jedbrown force-pushed the jed/fix-allgather-in-place-docs branch from c80a18d to 4ef8943 Compare August 1, 2024 19:35
@jsquyres jsquyres marked this pull request as draft August 1, 2024 20:01
@jsquyres jsquyres marked this pull request as ready for review August 1, 2024 20:01
@jsquyres jsquyres assigned jsquyres and bosilca and unassigned jsquyres Aug 1, 2024
@jsquyres
Copy link
Member

jsquyres commented Aug 1, 2024

Woof. I pressed all the wrong buttons on this PR.

@bosilca Can you review?

@wenduwan wenduwan merged commit 1fcf4db into open-mpi:main Aug 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants