oshmem/shmem: Fix sshmem start address and warn if inside data region #12764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: b68e689: oshmem/shmem: Fix sshmem start address and warn if...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
tvegas1
force-pushed
the
sshmem_start_addr_fix
branch
from
b68e689
to
8795f06
Compare
yosefe
approved these changes
Aug 28, 2024
|
@tvegas1 can you pls rebase? |
tvegas1
force-pushed
the
sshmem_start_addr_fix
branch
from
07e6b83
to
2c0dc9d
Compare
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 2c0dc9d: oshmem/shmem: Fix sshmem start address and warn if...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
tvegas1
force-pushed
the
sshmem_start_addr_fix
branch
from
2c0dc9d
to
32c4c49
Compare
yosefe
approved these changes
Aug 28, 2024
Signed-off-by: Thomas Vegas <[email protected]>
tvegas1
force-pushed
the
sshmem_start_addr_fix
branch
from
32c4c49
to
669feb8
Compare
|
@tvegas1 please open up v5.0.x cherry-pick, don't forget to add the -x flag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms, the end of the data region is above our shared memory region. We end-up erroneously adding the UCX segment a second time as a static segment, causing corruption.
Possible workaround option:
-mca sshmem_base_start_address 0xbaaaab2c0000Internal: 3995436