Add step to print labels in build workflow#51
Merged
Conversation
sciros
reviewed
Apr 9, 2025
sciros
reviewed
Apr 9, 2025
Member
|
@ahanafy is this ready for review? I am generally in favor of this idea. |
Contributor
Author
Still fighting with the build. Although in principle the idea works. I'm having issues with setting the description as a multiline string |
…andard API implementation
…and update image versioning
… in build workflow
…pport in build workflow
…ed readability and URL-encoded newlines in build workflow
…pdate annotations format in build workflow
…ting output into a single line format
…mary with direct links
…ect links and pull command
…und service references
ahanafy
force-pushed
the
ah-container-build-clarity
branch
from
d77104f to
3158339
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new step to the build workflow that prints generated image labels and enhances tag generation with a shared output for branch names and timestamps. Key changes include:
- The introduction of the "shared-tags" job that generates and outputs branch names and timestamp values.
- Integration of the shared tag outputs into subsequent jobs for metadata extraction, image tagging, and summary generation.
- Updates to the unbound image build process with specific adjustments to image references and registry links.
Files not reviewed (1)
- api-implementation/Dockerfile: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/build.yml:304
- The change in subject-name replaces the dynamic matrix-service variable with a hardcoded 'unbound' value. If this is intentional, consider adding a comment to clarify the rationale to avoid confusion for future maintainers.
subject-name: ${{ env.REGISTRY }}/${{ github.repository_owner }}/unbound
sciros
reviewed
Apr 22, 2025
sciros
reviewed
Apr 22, 2025
sciros
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the GitHub Actions workflow for building and publishing Docker images by introducing shared tags, improving metadata management, and adding detailed summaries for build outputs. Additionally, it updates the base Python image in the
Dockerfile.Workflow Enhancements:
shared-tagsjob to generate reusable outputs for branch names, timestamps (ISO 8601 and legacy formats), and a summary of generated tags. These outputs are used across other jobs for consistency. (.github/workflows/build.yml, .github/workflows/build.ymlR20-R56)docker/metadata-actionconfiguration to use the shared tags for generating Docker image tags and annotations. This includes adding descriptions and timestamps in the image annotations. (.github/workflows/build.yml, [1] [2].github/workflows/build.yml, [1] [2]Codebase Updates:
api-implementation/Dockerfilefrompython:3.13topython:3.13.2to ensure the latest patch version is used. (api-implementation/Dockerfile, api-implementation/DockerfileL2-R2)