feat: Include location in the result output #1196
Merged
+185
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow outputters to point to the specific location that caused the result to be created. Signed-off-by: James Alseth <[email protected]>
jalseth
force-pushed
the
jalseth/add-locs
branch
from
791e4e0 to
482900a
Compare
boranx
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
Nice feature! 👏
Maybe not that ideal for highly dynamic or order-shifting inputs, but it could be quite useful for strictly generated / idempotent ones.
One question: At what stage do you think it would make sense to mention it in the docs — to surface it to users?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow outputters to point to the specific location that caused the result to be created.
This is the first part of addressing #1194.
Also parallelized the other tests in
output/result_test.go.