Add k8sallowedreposv2 Policy with Exact Match & Glob Support #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yakirk <[email protected]>
Signed-off-by: yakirk <[email protected]>
|
Hey @maxsmythe @JaydipGabani @ritazh and @sozercan |
|
@yakirk we are updating our library to include CEL logic as well. Are you interested in adding CEL engine code for this policy? Here is a sample policy that is a good starting point - https://open-policy-agent.github.io/gatekeeper-library/website/validation/requiredlabels. |
|
@JaydipGabani , thanks for the suggestion! I'm not familiar with CEL syntax yet, so I'd prefer merging the current policy for now. I may revisit adding a CEL policy later. |
|
@yakirk Sounds good, we need approval from one more maintainer to merge. @ritazh @maxsmythe PTAL |
|
Hey @JaydipGabani @maxsmythe @ritazh, |
maxsmythe
approved these changes
Jan 15, 2025
Signed-off-by: Yakir Kadkoda <[email protected]>
Update allowedrepos version to 1.0.2 Signed-off-by: yakirk <[email protected]>
Update allowedrepos version to 1.0.2
ritazh
reviewed
Jan 15, 2025
Signed-off-by: Yakir Kadkoda <[email protected]>
fix: Correct pod name in example_allowed_images
Signed-off-by: Yakir Kadkoda <[email protected]>
Signed-off-by: Yakir Kadkoda <[email protected]>
Signed-off-by: Yakir Kadkoda <[email protected]>
Fix: Update and Correct samples and suite.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new k8sallowedreposv2 policy that improves the current k8sallowedrepos rule by adding support for exact matches and glob-like patterns. This makes it easier to create more precise and flexible rules for allowed container images.
What’s New?
New Policy - k8sallowedreposv2:Supports exact image names and glob-like syntax for better control.
Provides an alternative to the current prefix-only approach of k8sallowedrepos .
Documentation Update: Improved the k8sallowedrepos documentation to highlight the importance of adding a "/" when specifying DockerHub repositories, custom registries, and more.
This ensures users avoid potential bypasses, like allowing malicious registries or repositories with similar prefixes.
This change addresses security concerns discussed previously: #538 and #529
And provides a clearer, more secure way to define allowed container images.