Added support to configure the multiple lpars. #787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PraveenPenguin @SamirMulani we can still limit this change to single input parameter can we remove lpar_config parameter... and make sure to perform lpar config if more than one lpar given in lpar_list ? |
abdhaleegit
requested changes
Oct 26, 2023
testcases/MachineConfig.py
Outdated
| @@ -197,12 +229,13 @@ def LparSetup(self): | |||
| self.overcommit_ratio = 1 | |||
| proc_mode = 'shared' | |||
| curr_proc_mode = self.cv_HMC.get_proc_mode() | |||
| if proc_mode in curr_proc_mode: | |||
| print("==========================> samir===========================###########################: ", lpar_config) | |||
testcases/MachineConfig.py
Outdated
| log.info("System is already booted in shared mode.") | ||
| else: | ||
| self.cv_HMC.profile_bckup() | ||
| self.cv_HMC.change_proc_mode(proc_mode, self.sharing_mode, self.min_proc_units, | ||
| self.desired_proc_units, self.max_proc_units, self.overcommit_ratio) | ||
| self.desired_proc_units, self.max_proc_units, self.overcommit_ratio) |
There was a problem hiding this comment.
please run autopep8 to fix indents
This enhancement introduces support for configuring multiple lpars, such as lpar1, lpar2, and so on, especially when they are in shared mode. To configure the multiple lpars user need to pass below two parameters, lpar_config=multi lpar_lis=lpar1, lpar2 ...etc In this case, users are required to explicitly specify these two parameters in the .conf file, and it's important to ensure that all lpars have unique passwords. Signed-off-by: Samir Mulani <[email protected]> Added support to configure the multiple lpars. In this commit addressed review comments, 1. Removed lpar_config option. Signed-off-by: Samir Mulani <[email protected]> Added support to configure the multiple lpars. Addressed review comments. 1. Fixed indentation issues. 2. Removed unwanted debug print statement. Signed-off-by: Samir Mulani <[email protected]>
SamirMulani
force-pushed
the
multiconfig
branch
from
1d15dff to
b041044
Compare
We've made adjustments to the conditions for checking multiple LPAR configurations. Now, during the configuration process for multiple LPARs, if an LPAR is already in shared mode, we've also included support for modifying the EC (Entitlement Capacity) versus VP (Virtual Processore Signed-off-by: Samir Mulani <[email protected]>
|
@abdhaleegit @PraveenPenguin Created a new pull request with all requested changes, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement introduces support for configuring multiple lpars, such as lpar1, lpar2, and so on, especially when they are in shared mode.
To configure the multiple lpars user needs to pass below two parameters,
In this case, the user is required to explicitly specify these two parameters in the .conf file, and it's important to ensure that all lpars have unique passwords.