Added Redfish API for following operation #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdhaleegit
requested changes
Apr 16, 2024
There was a problem hiding this comment.
@maramsmurthy Thanks for the PR, few things to change
- no need of new testcase, add code in existing MachineConfg.py
- this is config set so values to be set is passed as key value pair by user iocapacity=12 and code sets it and validate
- add the code inside Class CecConfig
- make sure you move the methods to set and get iocapcity inside CecConfig class
- if iocapcity param is not given.. than do nothing
|
Please upload the logs |
|
@maramsmurthy Please push the latest code |
maramsmurthy
force-pushed
the
maramsmurthy_ioenlarge_redfish
branch
3 times, most recently
from
10c385b to
50b7c76
Compare
PraveenPenguin
requested changes
May 11, 2024
There was a problem hiding this comment.
@maramsmurthy split commit in at least two commit as that will good to have logical code changes history
maramsmurthy
force-pushed
the
maramsmurthy_ioenlarge_redfish
branch
2 times, most recently
from
6f0e2f1 to
28d5f1c
Compare
|
Console output when test was executed(EBMC - rainier) |
|
@maramsmurthy Please rebase the code |
|
20240510100708296825.debug.log debug log file |
|
if self.bmc_type == "FSP_PHYP": elif self.bmc_type == "EBMC": |
maramsmurthy
force-pushed
the
maramsmurthy_ioenlarge_redfish
branch
from
28d5f1c to
198e561
Compare
|
@maramsmurthy the code is outdated again,.. looks like unrelated files/changes are part of your PR.. please recheck https://github.com/open-power/op-test/pull/819/files |
maramsmurthy
force-pushed
the
maramsmurthy_ioenlarge_redfish
branch
3 times, most recently
from
f10437f to
10d3113
Compare
abdhaleegit
reviewed
Jul 1, 2024
|
@maramsmurthy any update here? |
maramsmurthy
force-pushed
the
maramsmurthy_ioenlarge_redfish
branch
2 times, most recently
from
36b28cf to
ad3cf04
Compare
Reading a BIOS attribute using Redfish API Set value to BIOS attribute using Redfish API IOEnlarger capacity BIOS attribute can be updated and read Added call for FSP to set IO enlarge capacity value Signed-off-by: Maram Srimannarayana Murthy <[email protected]>
Removed duplicate API's in both common and machineconf file and simplified to make use of bmc.rest_api to call configured_enlarge_io() Signed-off-by: Abdul Haleem <[email protected]>
abdhaleegit
force-pushed
the
maramsmurthy_ioenlarge_redfish
branch
from
6020020 to
3d8a34b
Compare
PraveenPenguin
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading a BIOS attribute using Redfish API
Set value to BIOS attribute using Redfish API
IOEnlarger capacity BIOS attribute can be update and read using BMCRedFish.py