Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to configure the multiple lpars-v4 #829

Closed
wants to merge 3 commits into from

Conversation

SamirMulani
Copy link
Contributor

@SamirMulani SamirMulani commented Apr 23, 2024

Added support to configure the multiple lpars-v4

This enhancement introduces support for configuring multiple lpars, such as lpar1, lpar2, and so on, especially when they are in shared mode.

To configure the multiple lpars user need to pass below two parameters, lpar_config=multi
lpar_list=lpar1, lpar2 ...etc
In this case, users are required to explicitly specify these two parameters in the .conf file, and it's important to ensure that all lpars have unique passwords.

This enhancement introduces support for configuring multiple lpars,
such as lpar1, lpar2, and so on, especially when they are in shared mode.

To configure the multiple lpars user need to pass below two parameters,
lpar_config=multi
lpar_list=lpar1, lpar2 ...etc
In this case, users are required to explicitly specify these two parameters
in the .conf file, and it's important to ensure that all lpars have unique
passwords.

Signed-off-by: Samir Mulani <samir@linux.vnet.ibm.com>

Added support to configure the multiple lpars-v4

Removed unwanted print statement

Signed-off-by: Samir Mulani <samir@linux.vnet.ibm.com>
@abdhaleegit abdhaleegit self-requested a review April 29, 2024 05:40
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split up the pylint changes into different commit

This enhancement introduces support for configuring multiple lpars, such as lpar1, lpar2, and so on, especially when they are in shared mode.

To configure the multiple lpars user need to pass below two parameters, lpar_config=multi
lpar_list=lpar1, lpar2 ...etc
In this case, users are required to explicitly specify these two parameters in the .conf file, and it's important to ensure that all lpars have unique passwords.

Signed-off-by: Samir Mulani <samir@linux.vnet.ibm.com>
@SamirMulani
Copy link
Contributor Author

@abdhaleegit The above latest commit contains the actual changes required to enable multi-config.

@abdhaleegit
Copy link
Collaborator

@SamirMulani looks like both commits are same,, you need to change the commit name and descripton for pylint related changes.. if we merge this the history will look odd.. please repush with changes

@SamirMulani
Copy link
Contributor Author

A new version patch has been raised due to a merge conflict issue,
#837

@SamirMulani SamirMulani closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants