-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch fixes issue when login in BMC/eBMC is successful but response bo… #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PraveenPenguin
force-pushed
the
fix_token
branch
from
September 2, 2024 05:00
009542e
to
e58c015
Compare
log :
|
sacsant
reviewed
Sep 2, 2024
PraveenPenguin
force-pushed
the
fix_token
branch
from
September 2, 2024 06:02
e58c015
to
d90c369
Compare
PraveenPenguin
changed the title
Patch fixes issue when login in BMC/EMB is successful but response bo…
Patch fixes issue when login in BMC/eBMC is successful but response bo…
Sep 2, 2024
abdhaleegit
reviewed
Sep 2, 2024
PraveenPenguin
force-pushed
the
fix_token
branch
from
September 2, 2024 12:56
d90c369
to
3165f79
Compare
Depending on code level running on BMC/eBMC, expected format for a response on successful login operation may differ. Expected: status': 'ok' Actual: "token":"<token>" This patch adds code to handle this valid response. before FIx: Traceback (most recent call last): File "/home/shirisha_g/Desktop/Reinstall-202132021432/OPTEST-SETUP/op-test/common/OpTestUtil.py", line 2576, in login .format(r.status_code, json_data['status'], KeyError: 'status' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/shirisha_g/Desktop/Reinstall-202132021432/OPTEST-SETUP/op-test/OpTestConfiguration.py", line 939, in objs password=self.args.bmc_password) File "/home/shirisha_g/Desktop/Reinstall-202132021432/OPTEST-SETUP/op-test/common/OpTestEBMC.py", line 55, in __init__ r = self.conf.util_bmc_server.login() File "/home/shirisha_g/Desktop/Reinstall-202132021432/OPTEST-SETUP/op-test/common/OpTestUtil.py", line 2599, in login .format(self._url(uri), username, password, e)) common.Exceptions.HTTPCheck: Something happened with the HTTP Server. Review the following for more details Message="Requests post problem, check that your credentials are properly Signed-off-by: Praveen K Pandey <[email protected]>
PraveenPenguin
force-pushed
the
fix_token
branch
from
September 2, 2024 12:57
3165f79
to
a832140
Compare
abdhaleegit
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
one run on P10 and P11 bmc/ebmc would be better.. with these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dy has only Token
before FIx:
Traceback (most recent call last):
File "/home/shirisha_g/Desktop/Reinstall-202132021432/OPTEST-SETUP/op-test/common/OpTestUtil.py", line 2576, in login
.format(r.status_code, json_data['status'],
KeyError: 'status'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/shirisha_g/Desktop/Reinstall-202132021432/OPTEST-SETUP/op-test/OpTestConfiguration.py", line 939, in objs
password=self.args.bmc_password)
File "/home/shirisha_g/Desktop/Reinstall-202132021432/OPTEST-SETUP/op-test/common/OpTestEBMC.py", line 55, in init
r = self.conf.util_bmc_server.login()
File "/home/shirisha_g/Desktop/Reinstall-202132021432/OPTEST-SETUP/op-test/common/OpTestUtil.py", line 2599, in login
.format(self._url(uri), username, password, e))
common.Exceptions.HTTPCheck: Something happened with the HTTP Server. Review the following for more details Message="Requests post problem, check that your credentials are properly