Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key-type specific en- / decoder #597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wbeck10
Copy link

@wbeck10 wbeck10 commented Dec 20, 2024

Encoding and decoding of oqs keys using type specific en- / decoding is not working.
This pull requests adds type specific key der en- / decoding.

This PR will solve Fixes #562

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wbeck10 -- much better with the use of the jinja code generation logic! At first glance this looks OK but can I ask you to run the code formatter as per https://github.com/open-quantum-safe/oqs-provider/blob/main/CONTRIBUTING.md#coding-style and check the result in such as to be able to run all tests in CI? Getting "DCO" to green would also be nice, but I'm not hung up on that.

@ryjones
Copy link

ryjones commented Dec 20, 2024

git commit --amend --author="Wolfgang Beck <[email protected]>" --no-edit

Per-repo:
git config user.email "[email protected]"

If you want it global:
git config --global user.email "[email protected]"

git push --force-with-lease origin encdec3

@baentsch
Copy link
Member

baentsch commented Jan 6, 2025

@wbeck10 please see guidance of @ryjones on "DCO"; also, re-based needed.

@wbeck10
Copy link
Author

wbeck10 commented Jan 13, 2025

Thanks @wbeck10 -- much better with the use of the jinja code generation logic! At first glance this looks OK but can I ask you to run the code formatter as per https://github.com/open-quantum-safe/oqs-provider/blob/main/CONTRIBUTING.md#coding-style and check the result in such as to be able to run all tests in CI? Getting "DCO" to green would also be nice, but I'm not hung up on that.

Sorry for the delay. I had a couple of weeks holiday :). I've fixed the formatter issues.

@wbeck10
Copy link
Author

wbeck10 commented Jan 14, 2025

I don't know why the macOS-noopenssl test is failing with:
error registering mldsa44 with no hash

I don't think this is caused by my changes.

@baentsch
Copy link
Member

No worries, this is due to #621: oqsprovider needs to change its algorithm names and code generation logic substantially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i2d_PublicKey() fails with -1 for DILITHIUM2 key while using OQS provider with OpenSSL 3.2.1
3 participants