-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add key-type specific en- / decoder #597
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wbeck10 -- much better with the use of the jinja code generation logic! At first glance this looks OK but can I ask you to run the code formatter as per https://github.com/open-quantum-safe/oqs-provider/blob/main/CONTRIBUTING.md#coding-style and check the result in such as to be able to run all tests in CI? Getting "DCO" to green would also be nice, but I'm not hung up on that.
Per-repo: If you want it global:
|
Signed-off-by: Wolfgang Beck <[email protected]>
Sorry for the delay. I had a couple of weeks holiday :). I've fixed the formatter issues. |
I don't know why the macOS-noopenssl test is failing with: I don't think this is caused by my changes. |
No worries, this is due to #621: oqsprovider needs to change its algorithm names and code generation logic substantially. |
Encoding and decoding of oqs keys using type specific en- / decoding is not working.
This pull requests adds type specific key der en- / decoding.
This PR will solve Fixes #562