Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: view on open sauced #278

Merged
merged 7 commits into from
Nov 5, 2023
Merged

fix: view on open sauced #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
29d1eed
fix: margin reduced to two
a0m0rajab Nov 4, 2023
38ee701
fix: add your own profile edge case
a0m0rajab Nov 4, 2023
5b82cc1
fix: adjust the margin to bottom only
a0m0rajab Nov 4, 2023
746fcae
fix: show the button on top of GitHub CTAs
a0m0rajab Nov 4, 2023
121587d
chore: update the constants file
a0m0rajab Nov 4, 2023
0969cc9
chore: renaming and removing extra code
a0m0rajab Nov 4, 2023
12e20e5
chore: lint
a0m0rajab Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ export const OPEN_SAUCED_EMOJIS_ENDPOINT = `${OPEN_SAUCED_API_ENDPOINT}/emojis`;
// Content-scripts selectors
export const GITHUB_PROFILE_MENU_SELECTOR = ".p-nickname.vcard-username.d-block";
export const GITHUB_PROFILE_EDIT_MENU_SELECTOR = "button.js-profile-editable-edit-button";
export const GITHUB_PROFILE_USER_PROFILE_BIO_SELECTOR = ".p-note.user-profile-bio.mb-3.js-user-profile-bio.f4";
export const GITHUB_PROFILE_USER_PROFILE_EDITABLE_AREA_SELECTOR = "js-profile-editable-area d-flex flex-column d-md-block";
export const GITHUB_PR_COMMENT_HEADER_SELECTOR = "timeline-comment-header clearfix d-flex";
export const GITHUB_NEW_PR_COMMENT_EDITOR_SELECTOR = "flex-nowrap d-none d-md-inline-block mr-md-0 mr-3";
export const GITHUB_PR_COMMENT_EDITOR_SELECTOR = "flex-nowrap d-inline-block mr-3";
Expand Down
3 changes: 1 addition & 2 deletions src/content-scripts/components/ViewOnOpenSaucedButton/ViewOnOpenSaucedButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ export const ViewOnOpenSaucedButton = (username: string) => {
const viewOnOpenSaucedButton = createHtmlElement("a", {
id: "view-on-opensauced-button",
href: `https://${OPEN_SAUCED_INSIGHTS_DOMAIN}/user/${username}/contributions`,
className:
"inline-block my-4 text-black bg-gh-white dark:bg-gh-gray dark:text-white rounded-md p-2 text-sm font-semibold text-center select-none w-full border hover:shadow-button hover:no-underline",
className: "inline-block mb-2 text-black bg-gh-white dark:bg-gh-gray dark:text-white rounded-md p-2 text-sm font-semibold text-center select-none w-full border hover:shadow-button hover:no-underline",
target: "_blank",
rel: "noopener noreferrer",
innerHTML: `
Expand Down
15 changes: 9 additions & 6 deletions src/utils/dom-utils/viewOnOpenSauced.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { GITHUB_PROFILE_USER_PROFILE_EDITABLE_AREA_SELECTOR } from "../../constants";
import { ViewOnOpenSaucedButton } from "../../content-scripts/components/ViewOnOpenSaucedButton/ViewOnOpenSaucedButton";

const injectViewOnOpenSaucedButton = (username: string) => {
Expand All @@ -8,12 +7,16 @@ const injectViewOnOpenSaucedButton = (username: string) => {

const viewOnOpenSaucedButton = ViewOnOpenSaucedButton(username);

const userEditableArea = document.getElementsByClassName(
GITHUB_PROFILE_USER_PROFILE_EDITABLE_AREA_SELECTOR,
);
const editableAreaElement = userEditableArea[0];
const editProfileButtonSelector = ".btn-block.js-profile-editable-edit-button";
const editProfileButton = document.querySelector(editProfileButtonSelector);

editableAreaElement.parentNode?.insertBefore(viewOnOpenSaucedButton, editableAreaElement);
if (editProfileButton) {
editProfileButton.parentNode?.insertBefore(viewOnOpenSaucedButton, editProfileButton);
} else {
const callToActionButtonsArea = document.querySelector(".js-user-profile-follow-button")?.closest(".flex-order-1.flex-md-order-none");

callToActionButtonsArea?.insertBefore(viewOnOpenSaucedButton, callToActionButtonsArea.firstChild);
}
};

export default injectViewOnOpenSaucedButton;
Loading