-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add UserActionInstrumentation #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joaquin-diaz
wants to merge
4
commits into
open-telemetry:main
Choose a base branch
from
embrace-io:joaquin-diaz/feat/add-basic-user-action-instrumentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add UserActionInstrumentation #35
joaquin-diaz
wants to merge
4
commits into
open-telemetry:main
from
embrace-io:joaquin-diaz/feat/add-basic-user-action-instrumentation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ff62925 to
fb3b29e
Compare
fb3b29e to
e888059
Compare
BenoitZugmeyer
approved these changes
Oct 30, 2025
overbalance
approved these changes
Nov 5, 2025
martinkuba
reviewed
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an existing web-common package. It might be confusing to have two similar packages published in npm. I suggest that we either move web-common to this repo, or add these utils there for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add the first iteration of the user action instrumentation only covering the mousedown event based on the current semantic conventions PR
Extras
Vitest
Simple vitest setup for running unit tests using jsdom
Initial monorepo setup
Preparing for a future turbopack integration, I set up some packages for the upcoming monorepo setup.
Each package has these set of scripts:
Once we set up a monorepo tool (possible turbopack) we can easily run these commands from root
TODO: make sure package can build
What's not included