New component observer/cfgardenobserver #33727
Open
+607
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jose Riguera <[email protected]> Co-authored-by: Sam Clulow <[email protected]> Co-authored-by: Tomas Mota <[email protected]>
Co-authored-by: Jose Riguera <[email protected]> Co-authored-by: Sam Clulow <[email protected]> Co-authored-by: Tomas Mota <[email protected]>
github-actions
bot
added
cmd/otelcontribcol
crobert-1
reviewed
Jun 27, 2024
|
This PR should also have a changelog entry, and the |
tomasmota
force-pushed
the
observer/cfgardenobserver-1
branch
from
118247c
to
9da35ce
Compare
|
Thanks for the review @crobert-1 , we have made the requested changes. |
tomasmota
force-pushed
the
observer/cfgardenobserver-1
branch
from
8b36717
to
54d1e9a
Compare
tomasmota
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
dashpole,
jpkrohling,
TylerHelmuth,
yurishkuro,
codeboten,
mx-psi,
Aneurysm9,
fatsheep9146,
songy23 and
bryan-aguilar
as code owners
crobert-1
added
cmd/otelcontribcol
|
There are quite a few CI/CD action failures, and they appear to be related to the changes in this PR. I'll hold off on reviewing again until they're resolved. |
|
Thanks @crobert-1 and @MovieStoreGuy, I have made the changes and the ci is now passing. Thank you for your reviews |
crobert-1
reviewed
Jul 2, 2024
crobert-1
reviewed
Jul 3, 2024
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We would like to implement a new observer for Cloudfoundry containers/applications. The idea is not make use of the main API but the local one, which is available as unix socket on each node and manages the containers lifecycle. The main API would remain as optional and only to get Application info (which only involves one GET http request once the app id is known).
Link to tracking Issue: 33618
Testing: First component PR
Documentation: Added Readme