Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/opamp] Report Available Components via OpAMP extension #37249

Conversation

mrsillydog
Copy link
Contributor

@mrsillydog mrsillydog commented Jan 15, 2025

Description

This feature implements support for the new AvailableComponents message in opamp-go for the OpAMP extension:
open-telemetry/opamp-go#340

Since the AvailableComponents message has not yet been released, this PR contains replace directives for testing purposes. This PR will not be merged until opamp-go has been released with the new AvailableComponents message implementation, at which point the replace directives will be removed. opamp-go v0.19.0 has been released.

This PR is one of two that make up #38136

Link to tracking issue

Fixes #37246

Testing

Updated unit tests
Manual end-to-end testing using the OpAMP supervisor and an external OpAMP server.

Documentation

Updated README

@mrsillydog mrsillydog changed the title Report Available Components via OpAMP extension [extension/opamp] Report Available Components via OpAMP extension Jan 15, 2025
@mrsillydog mrsillydog marked this pull request as ready for review January 27, 2025 19:08
@mrsillydog mrsillydog requested a review from a team as a code owner January 27, 2025 19:08
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 20, 2025
@github-actions github-actions bot removed the Stale label Feb 21, 2025
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the mod conflict

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mrsillydog!

@evan-bradley evan-bradley merged commit a9d996e into open-telemetry:main Feb 28, 2025
156 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 28, 2025
@mrsillydog mrsillydog deleted the feat/available-components-opamp-extension branch February 28, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[extension/opamp] Report AvailableComponents via the OpAMP extension
4 participants