-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/opamp] Report Available Components via OpAMP extension #37249
Merged
evan-bradley
merged 24 commits into
open-telemetry:main
from
observIQ:feat/available-components-opamp-extension
Feb 28, 2025
Merged
[extension/opamp] Report Available Components via OpAMP extension #37249
evan-bradley
merged 24 commits into
open-telemetry:main
from
observIQ:feat/available-components-opamp-extension
Feb 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
djaglowski
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the mod conflict
evan-bradley
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mrsillydog!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature implements support for the new AvailableComponents message in opamp-go for the OpAMP extension:
open-telemetry/opamp-go#340
Since the AvailableComponents message has not yet been released, this PR contains replace directives for testing purposes. This PR will not be merged until opamp-go has been released with the new AvailableComponents message implementation, at which point the replace directives will be removed.opamp-go v0.19.0 has been released.This PR is one of two that make up #38136
Link to tracking issue
Fixes #37246
Testing
Updated unit tests
Manual end-to-end testing using the OpAMP supervisor and an external OpAMP server.
Documentation
Updated README