[cmd/opampsupervisor] Report AvailableComponents via OpAMP supervisor #37250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
atoulme,
evan-bradley and
tigrannajaryan
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
djaglowski
approved these changes
Feb 28, 2025
cmd/opampsupervisor/testdata/supervisor/supervisor_reports_available_components.yaml
Outdated
Show resolved
Hide resolved
evan-bradley
approved these changes
Feb 28, 2025
For sure! Very appreciative of the quick turnaround after feedback responses! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature implements support for the new AvailableComponents message in opamp-go for the OpAMP supervisor:
open-telemetry/opamp-go#340
Since the AvailableComponents message has not yet been released, this PR contains replace directives for testing purposes. This PR will not be merged until opamp-go has been released with the new AvailableComponents message implementation, at which point the replace directives will be removed.opamp-go v0.19.0 has been released.This PR is one of two that make up #37248
Link to tracking issue
Fixes #37247
Testing
Updated unit tests
Manual end-to-end testing using the OpAMP extension and an external OpAMP server.
Documentation
Updated README