[receiver/awsfirehose] add cloud.provider=aws to cwlog resource attributes #37968
+155
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is worth a changelog entry, otherwise initial review looks good. |
* main: (22 commits) [receiver/awsfirehose] Add support for encoding extensions (open-telemetry#37262) fix(deps): update module google.golang.org/api to v0.223.0 (open-telemetry#38181) [chore] skip TestSyslogComplementaryRFC3164 (open-telemetry#38240) fix(deps): update module github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common to v1.0.1106 (open-telemetry#38199) [provider/s3] Use mdatagen, promote to alpha (open-telemetry#38227) fix: fix flaky test in kafkatopicsobserver (open-telemetry#38218) [processor/resourcedetection] Add k8s.cluster.uid to kubeadm detector (open-telemetry#38216) Revert "Add issue generation from fkaly tests for all archs (open-telemetry#38191)" (open-telemetry#38230) Revert "Introduce issuegenerator to open issues when tests fail on main (open-telemetry#38177)" (open-telemetry#38231) [chore] Update otelcol core dependency (open-telemetry#38214) [pkg/stanza] Improve error logs produced by transformer processors (open-telemetry#37285) [receiver/statsd] Make full config structure public (open-telemetry#38186) processor/metricsstarttime: add ridwanmsharif as codeowner (open-telemetry#38193) fix(deps): update module github.com/huaweicloud/huaweicloud-sdk-go-v3 to v0.1.137 (open-telemetry#38154) [pkg/datadog] export StaticAPIKeyCheck (open-telemetry#38223) [chore][pkg/ottl] Move scope and resource PathGetSetters to internal ctx packages (open-telemetry#38225) fix(deps): update all github.com/datadog packages to v0.64.0-rc.3 (open-telemetry#38202) feat(telemetrygen): added support for delta temporality (open-telemetry#38146) [chore] Some more fixes of component IDs (open-telemetry#38221) [chore][pkg/ottl] Define PathGetSetter in ctxdatapoint (open-telemetry#38201) ...
yiquanzhou
changed the title
|
Thanks @dehaansa for the initial review. I merged the latest repo changes and added the changelog. There's a flaky integration test |
Co-authored-by: Sam DeHaan <[email protected]>
dehaansa
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
cloud.provider=awsto resource attributes of CloudWatch logs ingested byawsfirehosereceiver. This attribute has been added forcwmetricbut probably forgotten forcwloghttps://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/awsfirehosereceiver/internal/unmarshaler/cwmetricstream/unmarshaler.go#L152
Add
aws.log.group.namesandaws.log.stream.namesattributes that are specified in the semconvs to replaceaws.cloudwatch.log_group_nameandaws.cloudwatch.log_stream_nameSet scope name and version of logs and metrics