[testbed] fix load gen worker tick interval math to avoid div by zero #38084
+101
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavincabbage
force-pushed
the
fix-testbed-div-by-zero
branch
from
c23fc23 to
9503ba8
Compare
gavincabbage
changed the title
dehaansa
requested changes
Feb 28, 2025
| // Because of the way perWorkerTickDuration calculates the tick interval using dataItemsPerSecond, | ||
| // it is important to test its behavior with respect to a one-second Duration in particular. | ||
| { | ||
| name: "less than one second", |
There was a problem hiding this comment.
Since this change is to resolve the divide by zero risk, we should have a test case that would have previously resulted in the divide by zero panic.
There was a problem hiding this comment.
Thanks for the review @dehaansa! One of the test cases was as you describe (indeed it was the set of configuration that caused me to find this bug in the first place). I've made the comment and test name more explicit on this point.
dehaansa
approved these changes
Feb 28, 2025
dehaansa
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, certain combinations of load generation options could lead to an attempt to divide by zero, resulting in a panic. Specifically, if the desired batches per second of a single worker was calculated to be less than one, integer division caused it to be rounded to zero before using it as the divisor in subsequent calculations.
Testing
The logic was refactored into a standalone method and tested by unit tests added in this PR.