[connector/signaltometrics]Drop get OTTL func in favor of OTTL's ParseValueExpression #38101
+72
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
commented
Feb 28, 2025
andrzej-stencel
approved these changes
Feb 28, 2025
Co-authored-by: Andrzej Stencel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The component was using an internal
getOTTL function as a stop gap measure to extract value from OTTL expressions due to lack of such function from the core OTTL library. With #35621, support for data extraction using OTTL value expressions was introduced. This PR uses theParseValueExpressionmethod and drops thegetOTTL function. The function was documented in README as internal function and strictly advised not to be used in configurations so I don't expect any issues.Link to tracking issue
Fixes #38098
Testing
Unit tests are passing
Documentation
README is updated