Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add SAPM deprecation metadata #38144

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 24, 2025

Description

See open-telemetry/opentelemetry-collector#12359

Add more deprecation metadata to the sapm components.

@ChrsMark
Copy link
Member

Shall we ignore the metadata validation failure for now?

Error: failed loading /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/sapmreceiver/metadata.yaml: decoding failed due to the following error(s):

'status' has invalid keys: deprecation
Error: failed loading /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/sapmreceiver/metadata.yaml: decoding failed due to the following error(s):

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13507291093/job/37739730675?pr=38144#step:16:111

@atoulme
Copy link
Contributor Author

atoulme commented Feb 25, 2025

I was hoping the yaml deserializer would be ok with additional fields. Now we have to synchronize all the PRs.

I will make a change to mdatagen to ignore additional fields, then we can update mdatagen, then we can roll this up.

@atoulme
Copy link
Contributor Author

atoulme commented Feb 25, 2025

open-telemetry/opentelemetry-collector#12484 is open to attend to this.

@dmitryax
Copy link
Member

Why do we want add new fields that are not being used?

@atoulme
Copy link
Contributor Author

atoulme commented Feb 26, 2025

open-telemetry/opentelemetry-collector#12359

You can see the issue here: open-telemetry/opentelemetry-collector#12464
We want to add a new field to components in contrib, then add support for it.

@dmitryax
Copy link
Member

Makes sense. Why don't implement it first instead of open-telemetry/opentelemetry-collector#12484?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants