Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add faro reciever #38224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dark0dave
Copy link

@dark0dave dark0dave commented Feb 26, 2025

Add a faro receiver from grafana's code base.

Description

Add faro reciever #19180

Link to tracking issue

Fixes #19180

Testing

Documentation

@dark0dave dark0dave requested a review from a team as a code owner February 26, 2025 14:52
@dark0dave dark0dave requested a review from dehaansa February 26, 2025 14:52
Copy link

linux-foundation-easycla bot commented Feb 26, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dark0dave / name: dark0dave (983990f)

@dark0dave dark0dave force-pushed the feature/faro branch 8 times, most recently from 49dfbd2 to f1d837a Compare February 26, 2025 17:33
@dark0dave dark0dave changed the title Draft: feat: Add faro reciever feat: Add faro reciever Feb 26, 2025
@atoulme atoulme added the Sponsor Needed New component seeking sponsor label Feb 27, 2025
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Feb 28, 2025
@dark0dave dark0dave force-pushed the feature/faro branch 3 times, most recently from 6c75fd6 to 59990cb Compare February 28, 2025 15:55
@dark0dave
Copy link
Author

@dehaansa , I have this running locally, I am just missing a sponsor
image

@dehaansa
Copy link
Contributor

@dehaansa , I have this running locally, I am just missing a sponsor

Thanks! I'll start to take a look. I believe the original issue raiser @rlankfo is OOO this week, and I'm interested in getting their feedback as well, but I'll mark myself as a sponsor.

@dehaansa dehaansa added Accepted Component New component has been sponsored and removed Sponsor Needed New component seeking sponsor labels Feb 28, 2025
@dehaansa
Copy link
Contributor

dehaansa commented Mar 1, 2025

I'm happy to review initially here, but forgot to mention - the preferred way to contribute a new component is in parts. First up is a wireframe of the receiver, similar to this active PR.

See docs in the CONTRIBUTING guide for details of what each PR should include.


func (r *faroReceiver) Start(ctx context.Context, host component.Host) error {
r.settings.Logger.Info("Starting FaroReceiver")
if r.nextTraces == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are both of these absolutely required? Or could a user find value in just logs or just traces and not want them both to be consumed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So my thinking is as follows, the faro sdk users can send traces/logs, ideally the collector should be setup to receive both, without requiring separate setup. But if you disagree happy to alter.

@dark0dave
Copy link
Author

I'm happy to review initially here, but forgot to mention - the preferred way to contribute a new component is in parts. First up is a wireframe of the receiver, similar to this active PR.

See docs in the CONTRIBUTING guide for details of what each PR should include.

How would you like me to proceed? Should I add the wireframe in a separate pr or continue here?

Thank you for your guidance!

@dark0dave dark0dave force-pushed the feature/faro branch 3 times, most recently from 6f63f6d to 6c18df8 Compare March 1, 2025 15:46
@dehaansa
Copy link
Contributor

dehaansa commented Mar 2, 2025

I'm happy to review initially here, but forgot to mention - the preferred way to contribute a new component is in parts. First up is a wireframe of the receiver, similar to this active PR.
See docs in the CONTRIBUTING guide for details of what each PR should include.

How would you like me to proceed? Should I add the wireframe in a separate pr or continue here?

Thank you for your guidance!

Yes, you'll have to do the separate PRs, starting with the wireframe. I wanted to get the review on this PR since you had the whole picture here already, but it's the accepted process for new components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Component New component has been sponsored cmd/otelcontribcol otelcontribcol command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New component: Faro Receiver
4 participants