-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add faro reciever #38224
base: main
Are you sure you want to change the base?
feat: Add faro reciever #38224
Conversation
|
49dfbd2
to
f1d837a
Compare
f1d837a
to
40c8883
Compare
6c75fd6
to
59990cb
Compare
@dehaansa , I have this running locally, I am just missing a sponsor |
|
||
func (r *faroReceiver) Start(ctx context.Context, host component.Host) error { | ||
r.settings.Logger.Info("Starting FaroReceiver") | ||
if r.nextTraces == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both of these absolutely required? Or could a user find value in just logs or just traces and not want them both to be consumed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my thinking is as follows, the faro sdk users can send traces/logs, ideally the collector should be setup to receive both, without requiring separate setup. But if you disagree happy to alter.
How would you like me to proceed? Should I add the wireframe in a separate pr or continue here? Thank you for your guidance! |
6f63f6d
to
6c18df8
Compare
Yes, you'll have to do the separate PRs, starting with the wireframe. I wanted to get the review on this PR since you had the whole picture here already, but it's the accepted process for new components. |
Add a faro receiver from grafana's code base.
Description
Add faro reciever #19180
Link to tracking issue
Fixes #19180
Testing
Documentation