Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][pkg/stanza] - finalize archive's implementation #38267

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[chore][pkg/stanza] - finalize archive's implementation #38267

wants to merge 5 commits into from
+119 −18

Conversation

VihasMakwana
Copy link
Contributor

This PR finalizes the archive implementation and adds test case.

@djaglowski I think we can add more sophisticated test cases once we establish common ground on the implementation.

Relates: #38056

@VihasMakwana VihasMakwana requested review from djaglowski and a team as code owners February 28, 2025 12:28
@VihasMakwana VihasMakwana added the enhancement New feature or request label Feb 28, 2025
@VihasMakwana
Copy link
Contributor Author

VihasMakwana commented Feb 28, 2025 •
edited
Loading

One thing remains i.e. to update Config struct to allow polls_to_archive to be unmarshalled. I think we can do that in documentation PR afterwards.

@VihasMakwana VihasMakwana added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 28, 2025
@VihasMakwana
Copy link
Contributor Author

I'll add changelog in documentation PR, as that will enable the actual config.

@VihasMakwana VihasMakwana mentioned this pull request Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@djaglowski djaglowski

Labels
enhancement New feature or request pkg/stanza Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VihasMakwana @djaglowski