[chore] initialize carbon receiver with compatible id #38283

atoulme · 2025-02-28T22:48:04Z

This fixes contrib-tests for core, as a new validation fails when creating a carbon receiver with the wavefront receiver receiver settings.

Currently, tests fail with:

=== Failed
=== FAIL: . TestComponentLifecycle/metrics-lifecycle (0.00s)
    generated_component_test.go:63: 
        	Error Trace:	/tmp/contrib/receiver/wavefrontreceiver/generated_component_test.go:63
        	Error:      	Received unexpected error:
        	            	component type mismatch: component ID "wavefront/50a66f9b-48cc-4338-9701-fd51487c5ecc" does not have type "carbon"
        	Test:       	TestComponentLifecycle/metrics-lifecycle

=== FAIL: . TestComponentLifecycle (0.00s)

=== FAIL: . Test_wavefrontreceiver_EndToEnd (0.00s)
    receiver_test.go:38: 
        	Error Trace:	/tmp/contrib/receiver/wavefrontreceiver/receiver_test.go:38
        	Error:      	Received unexpected error:
        	            	component type mismatch: component ID "wavefront/03ee0cef-57a4-4444-b7e2-18bdc84c22cc" does not have type "carbon"
        	Test:       	Test_wavefrontreceiver_EndToEnd

=== FAIL: . TestComponentLifecycle/metrics-lifecycle (re-run 1) (0.00s)
    generated_component_test.go:63: 
        	Error Trace:	/tmp/contrib/receiver/wavefrontreceiver/generated_component_test.go:63
        	Error:      	Received unexpected error:
        	            	component type mismatch: component ID "wavefront/b873a78a-6cc5-4dc2-9859-fc28142a28af" does not have type "carbon"
        	Test:       	TestComponentLifecycle/metrics-lifecycle

make[3]: *** [../../Makefile.Common:102: test] Error 1
make[2]: *** [Makefile:231: receiver/wavefrontreceiver] Error 2
make[1]: *** [Makefile:149: gotest] Error 2
make: *** [Makefile:278: check-contrib] Error 2
=== FAIL: . TestComponentLifecycle (re-run 1) (0.00s)

=== FAIL: . Test_wavefrontreceiver_EndToEnd (re-run 1) (0.00s)
    receiver_test.go:38: 
        	Error Trace:	/tmp/contrib/receiver/wavefrontreceiver/receiver_test.go:38
        	Error:      	Received unexpected error:
        	            	component type mismatch: component ID "wavefront/99cf9fcc-e9dc-438e-a41a-52b2c2c1f9f8" does not have type "carbon"
        	Test:       	Test_wavefrontreceiver_EndToEnd

See https://github.com/open-telemetry/opentelemetry-collector/actions/runs/13596976480/job/38016127009?pr=12528

bogdandrutu · 2025-02-28T22:57:16Z

receiver/wavefrontreceiver/receiver.go

+	carbonSettings := receiver.Settings{
+		ID:                component.MustNewIDWithName("carbon", r.set.ID.Name()),
+		TelemetrySettings: r.set.TelemetrySettings,
+		BuildInfo:         r.set.BuildInfo,
+	}
+
+	carbonReceiver, err := fact.CreateMetrics(ctx, carbonSettings, carbonCfg, r.nextConsumer)


Please do like here: #38284, it avoids mistakes to not copy all the fields.

atoulme · 2025-02-28T22:57:40Z

Closing in favor of #38284

[chore] initialize carbon receiver with compatible id

34a609a

atoulme requested a review from a team as a code owner February 28, 2025 22:48

atoulme requested a review from dashpole February 28, 2025 22:48

github-actions bot assigned crobert-1 Feb 28, 2025

github-actions bot added the receiver/wavefront label Feb 28, 2025

github-actions bot requested a review from samiura February 28, 2025 22:48

bogdandrutu reviewed Feb 28, 2025

View reviewed changes

atoulme closed this Feb 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[chore] initialize carbon receiver with compatible id #38283

[chore] initialize carbon receiver with compatible id #38283

atoulme commented Feb 28, 2025 •

edited

Loading

bogdandrutu Feb 28, 2025

atoulme commented Feb 28, 2025

[chore] initialize carbon receiver with compatible id #38283

[chore] initialize carbon receiver with compatible id #38283

Conversation

atoulme commented Feb 28, 2025 • edited Loading

bogdandrutu Feb 28, 2025

Choose a reason for hiding this comment

atoulme commented Feb 28, 2025

atoulme commented Feb 28, 2025 •

edited

Loading