Skip to content

Conversation

ericywl
Copy link
Contributor

@ericywl ericywl commented Sep 5, 2025

Description

Fix a bug where the data stream attributes in none mapping mode is incorrectly prefixed.

Link to tracking issue

Fixes #42454.

Testing

Unit tests.

Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks!

Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a changelog

Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit.

@ChrsMark
Copy link
Member

ChrsMark commented Sep 8, 2025

@ericywl thank's for fixing this! Please consider the nit suggestion from #42510 (comment) and if you agree update the branch. Then I will mark it as ready-to-merge.

@ChrsMark ChrsMark added the ready to merge Code review completed; ready to merge by maintainers label Sep 9, 2025
@songy23 songy23 merged commit 465570d into open-telemetry:main Sep 9, 2025
200 of 201 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/elasticsearch ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/elasticsearch] none mapping mode incorrectly applies Attributes prefix to data_stream.* attributes.
6 participants