[chore][cmd/mdatagen] fix #12298 unit tests failures #12477
+9
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudecatch
force-pushed
the
new-fix-mdatagen-internal-tests
branch
from
7270a2c to
9aacbce
Compare
|
the cla has been signed, could you please have a look? thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12477 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 469 469
Lines 25355 25355
=======================================
Hits 23327 23327
Misses 1619 1619
Partials 409 409 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Feb 26, 2025
|
looks like easycla still got stuck here |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
bogdandrutu
added a commit
that referenced
this pull request
Feb 28, 2025
Fixes #12298 Inspired by #12477, but looks like that PR is hard to pass queue merge. Signed-off-by: Bogdan Drutu <[email protected]>
|
Please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation is not working in the sample projects. I reviewed the PR that introduced these changes and found no explanation for them. I believe it’s reasonable to revert these changes, so I’ve created this PR.
Please let me know if I’ve missed anything. Thank you!
Link to tracking issue
Fixes #12298
Testing
Documentation