Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][cmd/mdatagen] fix #12298 unit tests failures #12474

Closed

Conversation

cuichenli
Copy link

Description

The current implementation is not working in the sample projects. I reviewed the PR that introduced these changes and found no explanation for them. I believe it’s reasonable to revert these changes, so I’ve created this PR.

Please let me know if I’ve missed anything. Thank you!

Link to tracking issue

Fixes #12298

Testing

$ cd cmd/mdatagen 
$ go install .
$ make generate 
$ git status  # run this to check there is no change in the generated files 
$ make test

Documentation

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (2e344f7) to head (b09e8fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12474   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         465      465           
  Lines       25194    25194           
=======================================
  Hits        23228    23228           
  Misses       1570     1570           
  Partials      396      396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 25, 2025
auto-merge was automatically disabled February 25, 2025 05:22

Pull Request is not mergeable

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 25, 2025
@cuichenli
Copy link
Author

i will create one new account and try it again 🤯

@cuichenli cuichenli closed this Feb 25, 2025
@gudecatch
Copy link

#12477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdatagen: metrics.go.tmpl broken filter import
3 participants