-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][cmd/mdatagen] fix #12298 unit tests failures #12474
Closed
cuichenli
wants to merge
8
commits into
open-telemetry:main
from
cuichenli:new-fix-mdatagen-internal-tests
Closed
[chore][cmd/mdatagen] fix #12298 unit tests failures #12474
cuichenli
wants to merge
8
commits into
open-telemetry:main
from
cuichenli:new-fix-mdatagen-internal-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Feb 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12474 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 465 465
Lines 25194 25194
=======================================
Hits 23228 23228
Misses 1570 1570
Partials 396 396 ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
February 25, 2025 05:22
Pull Request is not mergeable
i will create one new account and try it again 🤯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation is not working in the sample projects. I reviewed the PR that introduced these changes and found no explanation for them. I believe it’s reasonable to revert these changes, so I’ve created this PR.
Please let me know if I’ve missed anything. Thank you!
Link to tracking issue
Fixes #12298
Testing
Documentation