[configtls] Add omitempty tags to fields
#12311
Open
+70
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12311 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 467 467
Lines 25582 25582
=======================================
Hits 23381 23381
Misses 1785 1785
Partials 416 416 ☔ View full report in Codecov by Sentry. |
|
Test failures will be addressed by open-telemetry/opentelemetry-collector-contrib#37758. |
songy23
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 6, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description One option to help with open-telemetry/opentelemetry-collector#12311. We could also fix this after making that change, but I think the checks now better reflect the intent of the test.
songy23
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will dramatically reduce YAML output when marshaling config for many receivers and exporters since it's commonly used.
Link to tracking issue
Works toward #12191