An attempt to implement merged context #12318
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Feb 7, 2025
| return mc | ||
| } | ||
|
|
||
| func (mc mergedContext) Deadline() (time.Time, bool) { |
There was a problem hiding this comment.
This may be called multiple times, so I think we should pre-calculate this.
Comment on lines
+52
to
+53
| func (mc mergedContext) Done() <-chan struct{} { | ||
| return mc.ctx.Done() | ||
| } |
There was a problem hiding this comment.
We don't need to propagate this.
Comment on lines
+56
to
+63
| func (mc mergedContext) Err() error { | ||
| var mergedErr error | ||
| for _, c := range mc.ctxArr { | ||
| if err := c.Err(); err != nil { | ||
| mergedErr = multierr.Append(mergedErr, c.Err()) | ||
| } | ||
| } | ||
| return mergedErr | ||
| } |
| "go.uber.org/multierr" | ||
| ) | ||
|
|
||
| type mergedContext struct { |
There was a problem hiding this comment.
The scope is:
- Deadline is max of all.
- Keep a list of all SpanContext.
We just need these 2 things, not the whole contexts.
sfc-gh-sili
force-pushed
the
sili-fix-new-batching-context
branch
from
3ece739 to
dac5fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #
Testing
Documentation