-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connector,exporter,processor,receiver] Error out on mismatched type #12381
Conversation
42970e7
to
836dd39
Compare
836dd39
to
480e080
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (77.21%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12381 +/- ##
==========================================
- Coverage 92.16% 92.06% -0.11%
==========================================
Files 465 469 +4
Lines 25201 25323 +122
==========================================
+ Hits 23226 23313 +87
- Misses 1576 1602 +26
- Partials 399 408 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure we have tests for all the main use-cases.
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Tries to fix some of the contrib tests for open-telemetry/opentelemetry-collector/pull/12381 <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Updates open-telemetry/opentelemetry-collector/issues/12221
@bogdandrutu The remaining contrib failures are interesting. We have quite a few components that use other components under the hood. A couple of examples (but there a few more):
How should these components use the API? I think this is also interesting for telemetry: if a component creates other components under the hood, what should its telemetry look like? cc @djaglowski @jade-guiton-dd in case you have thoughts about this |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this unblocked now that #12357 is merged?
@codeboten I want to fix these first #12381 (comment) |
Filed open-telemetry/opentelemetry-collector-contrib/pull/38221 for fixing the remaining contrib tests. |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixes some component IDs that did not match the component type. For components that create other components I chose to go with `<child Type>/<parent Type>/<parent Name>` <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Needed for open-telemetry/opentelemetry-collector/pull/12381
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Tries to fix some of the contrib tests for open-telemetry/opentelemetry-collector/pull/12381 <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Updates open-telemetry/opentelemetry-collector/issues/12221
c1af501
Description
Error out on mismatched type for all component kinds. Same as #12305 but for all component kinds.
Link to tracking issue
Requires #12357
Fixes #12221