[chore] [exporterhelper/batcher] Ignore deprecated fields if new set #12502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the batcher config, ignore deprecated `min_size_items` and `max_size_items` fields if new `min_size` and `max_size` are set
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12502 +/- ##
==========================================
+ Coverage 92.16% 92.18% +0.02%
==========================================
Files 465 465
Lines 25201 25201
==========================================
+ Hits 23226 23232 +6
+ Misses 1576 1572 -4
+ Partials 399 397 -2 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the batcher config, ignore deprecated
min_size_itemsandmax_size_itemsfields if newmin_sizeandmax_sizeare set.A follow-up to #12486.