Fix bug where the error logged when conversion of data fails is always nil #12510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that in the logging statement (in all signals) we log
err
instead ofcErr
. The good part is that this is not a UB, because if we get to the point where that function is called, theerr
was nil otherwise and never modified again so not race condition in accessing it.Separate the lambda function in a different function so we don't repeat the same mistake of capturing other params by mistake.