Skip to content

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Sep 7, 2025

Contributes to #2481

This is a partial fix, to implement semantic version in the yaml parser.

Changes

Please provide a brief description of the changes here.

  • Implement semantic version checks for the file format.
    • The yaml parser checks the field file_format for major and minor version.
    • Changed every parser code from a static function to a method. This is to allow parsing depending on the format version seen, if necessary.
    • Adjusted all tests accordingly.
  • Fixed minor build issues seen in the integration PR
    • Changed IntegerAttributeValueConfiguration to use a long long instead of std::size_t, to better fit the attributes variant.
    • Fixed setenv, unsetenv in the unit tests for Windows.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner September 7, 2025 21:36
@marcalff marcalff added the pr:please-review This PR is ready for review label Sep 7, 2025
Copy link

codecov bot commented Sep 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.10%. Comparing base (dc58584) to head (0b29e0e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3629      +/-   ##
==========================================
- Coverage   90.11%   90.10%   -0.01%     
==========================================
  Files         221      221              
  Lines        7135     7135              
==========================================
- Hits         6429     6428       -1     
- Misses        706      707       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor nitpick on making the specialized ConfigurationParser::Parse* methods const if they don't modify the file version.

@marcalff
Copy link
Member Author

Looks good. Just a minor nitpick on making the specialized ConfigurationParser::Parse* methods const if they don't modify the file version.

Good point, I will fix that.

@marcalff marcalff merged commit 5540dae into main Sep 26, 2025
66 checks passed
@marcalff marcalff deleted the merge_config_semantic_version branch September 26, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants