-
Notifications
You must be signed in to change notification settings - Fork 500
[CONFIGURATION] File configuration - semantic version #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3629 +/- ##
==========================================
- Coverage 90.11% 90.10% -0.01%
==========================================
Files 221 221
Lines 7135 7135
==========================================
- Hits 6429 6428 -1
- Misses 706 707 +1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a minor nitpick on making the specialized ConfigurationParser::Parse* methods const if they don't modify the file version.
Good point, I will fix that. |
Contributes to #2481
This is a partial fix, to implement semantic version in the yaml parser.
Changes
Please provide a brief description of the changes here.
IntegerAttributeValueConfiguration
to use along long
instead ofstd::size_t
, to better fit the attributes variant.setenv
,unsetenv
in the unit tests for Windows.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes