-
Notifications
You must be signed in to change notification settings - Fork 499
[Metrics] New Attribute Processor for Exclude list #3633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3633 +/- ##
==========================================
- Coverage 90.05% 90.04% -0.00%
==========================================
Files 220 220
Lines 7081 7097 +16
==========================================
+ Hits 6376 6390 +14
- Misses 705 707 +2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new FilteringExcludeAttributesProcessor
class that filters out specified attributes from metrics, complementing the existing include-list functionality. The implementation follows the OpenTelemetry specification for stream configuration attribute filtering.
Key changes:
- Added
FilteringExcludeAttributesProcessor
class with exclude-list functionality - Implemented corresponding unit tests to validate the new processor behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h |
Adds new FilteringExcludeAttributesProcessor class implementation |
sdk/test/metrics/attributes_processor_test.cc |
Adds unit tests for the new exclude-list attribute processor |
sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h
Outdated
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/metrics/view/attributes_processor.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
The code looks ok, but the tests are inconclusive, and could be much stronger.
See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
Fixes #3546
Changes
Created a new Attribute processor for exclude list as filter only partially exists for allowed list
This is the doc of spec - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#stream-configuration
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes