-
Notifications
You must be signed in to change notification settings - Fork 840
Fix parsing configuration for TraceIdRatioBasedSampler on non standard locales + fix localization related test #6444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing configuration for TraceIdRatioBasedSampler on non standard locales + fix localization related test #6444
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you can consider CHANGELOG entry to cover this parsing fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6444 +/- ##
=======================================
Coverage 86.68% 86.68%
=======================================
Files 258 258
Lines 11878 11878
=======================================
Hits 10296 10296
Misses 1582 1582
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Fixes: #6451
Some tests failed on machines using another localization (decimal separator for numbers). I noticed this running the tests locally on a German Windows 11 machine. I tried to fix this by using culture specific test data and making the parsing of config values culture invariant.
Changes
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes