-
Notifications
You must be signed in to change notification settings - Fork 839
Fix and tests for multiple metric readers #6458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rajkumar-rangaraj
merged 6 commits into
open-telemetry:main
from
hannahhaering:multiple-metric-reader-tests
Sep 9, 2025
Merged
Fix and tests for multiple metric readers #6458
rajkumar-rangaraj
merged 6 commits into
open-telemetry:main
from
hannahhaering:multiple-metric-reader-tests
Sep 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: The SDK MUST NOT allow a MetricReader instance to be registered on more than one MeterProvider instance.
martincostello
approved these changes
Sep 1, 2025
Can you also update the CHANGELOG please, as this changes behaviour for users. |
Co-authored-by: Martin Costello <[email protected]>
Kielek
approved these changes
Sep 2, 2025
rajkumar-rangaraj
approved these changes
Sep 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6458 +/- ##
==========================================
+ Coverage 86.57% 86.74% +0.17%
==========================================
Files 258 258
Lines 11876 11878 +2
==========================================
+ Hits 10282 10304 +22
+ Misses 1594 1574 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
reviewed
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2938
Changes
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes