-
Notifications
You must be signed in to change notification settings - Fork 838
Configure Renovate #6459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Configure Renovate #6459
Conversation
Port changes from #6446.
Not supported here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6459 +/- ##
==========================================
- Coverage 86.68% 86.61% -0.08%
==========================================
Files 258 258
Lines 11876 11876
==========================================
- Hits 10295 10286 -9
- Misses 1581 1590 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
- Code analysers need extra work to upgrade. - Newer xunit packages do not support `net462`.
Fix accidental downgrade.
<PackageVersion Include="OpenTelemetry" Version="[$(OTelLatestStableVer),)" /> | ||
<PackageVersion Include="OpenTelemetry.Api" Version="[$(OTelLatestStableVer),)" /> | ||
<PackageVersion Include="OpenTelemetry.Api.ProviderBuilderExtensions" Version="[$(OTelLatestStableVer),)" /> | ||
<PackageVersion Include="OpenTelemetry.Exporter.InMemory" Version="[$(OTelLatestStableVer),)" /> | ||
<PackageVersion Include="OpenTelemetry.Extensions.Hosting" Version="[$(OTelLatestStableVer),)" /> | ||
<PackageVersion Include="OpenTelemetry.Extensions.Propagators" Version="[$(OTelLatestStableVer),)" /> | ||
<PackageVersion Include="OpenTracing" Version="[0.12.1,)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is main concern on from my side. Other are minors.
"[$(OTelLatestStableVer),)"
is not the same as "[$(OTelLatestStableVer),2.0)". It will allow to solve packages also with OpenTelemetry v2.0.0 if ever released.
<PackageVersion Include="Microsoft.CSharp" Version="[4.7.0]" /> | ||
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="[3.11.0-beta1.23525.2]" /> | ||
<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" /> | ||
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="[3.11.0-beta1.23525.2,)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work the same as:
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="[3.11.0-beta1.23525.2,)" /> | |
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.11.0-beta1.23525.2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is semantically equivalent, but makes it fall into the regex used in the renovate configuration file which makes it "pinned" and be ignored. There's commentary in the abandoned PR detailing the rationale behind various choices here.
I've tried to upgrade this dependency previously, and it was non trivial as new rules made the build fail. This makes it ignored until someone actively tries to upgrade it manually. Renovate or dependabot would just generate a broken PR.
<PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.9.0" /> | ||
<PackageVersion Include="OpenTelemetry.Instrumentation.GrpcNetClient" Version="1.9.0-beta.1" /> | ||
<PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="1.9.0" /> | ||
<PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.9.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we have 1.12.0 packages already. I am fine with keeping as is in this PR, and allow to fix it by renovate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I just unpinned it to let the PRs flow from dependabot. You can see in the description of this PR what updates are going to flow post-merge.
<PackageVersion Include="xunit" Version="[2.9.3,3.0)" /> | ||
<PackageVersion Include="xunit.runner.visualstudio" Version="[2.8.2,3.0)" /> | ||
<PackageVersion Include="xunit" Version="2.9.3" /> | ||
<PackageVersion Include="xunit.runner.visualstudio" Version="[2.8.2,)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.*
works only with .NET8 (it is fine) and .NET Framework 4.7.2 (we cannot update to such version).
Is there any option to prevent renovate with updates? If it can be configured. we could change it to
<PackageVersion Include="xunit.runner.visualstudio" Version="[2.8.2,)" /> | |
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" /> |
or keep previous version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no xunit
3.*
. There is however xunit.v3
1.*-3.*
- it's a completely different package.
This is the latest version for v2, and is unpinned so if there's ever a patch version for it we'll get the update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed the comment was on the other line.
True, but post merge we can just close the PR to ignore the v3 update. We'd still get a patch version of there ever was one for 2.
Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.
🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.
Detected Package Files
build/docker-compose.net8.0.yml
(docker-compose)build/docker-compose.net9.0.yml
(docker-compose).github/workflows/Component.BuildTest.yml
(github-actions).github/workflows/add-labels.yml
(github-actions).github/workflows/automation.yml
(github-actions).github/workflows/ci.yml
(github-actions).github/workflows/codeql-analysis.yml
(github-actions).github/workflows/concurrency-tests.yml
(github-actions).github/workflows/docfx.yml
(github-actions).github/workflows/dotnet-format.yml
(github-actions).github/workflows/fossa.yml
(github-actions).github/workflows/markdownlint.yml
(github-actions).github/workflows/ossf-scorecard.yml
(github-actions).github/workflows/package-validation.yml
(github-actions).github/workflows/post-release.yml
(github-actions).github/workflows/prepare-release.yml
(github-actions).github/workflows/publish-packages-1.0.yml
(github-actions).github/workflows/sanitycheck.yml
(github-actions).github/workflows/stale.yml
(github-actions).github/workflows/verifyaotcompat.yml
(github-actions)Directory.Packages.props
(nuget)build/Common.nonprod.props
(nuget)build/Common.prod.props
(nuget)build/Common.props
(nuget)build/Common.targets
(nuget)docs/logs/complex-objects/complex-objects.csproj
(nuget)docs/metrics/getting-started-aspnetcore/getting-started-aspnetcore.csproj
(nuget)docs/trace/getting-started-aspnetcore/getting-started-aspnetcore.csproj
(nuget)docs/trace/getting-started-jaeger/getting-started-jaeger.csproj
(nuget)global.json
(nuget)src/OpenTelemetry.Api.ProviderBuilderExtensions/OpenTelemetry.Api.ProviderBuilderExtensions.csproj
(nuget)src/OpenTelemetry.Api/OpenTelemetry.Api.csproj
(nuget)src/OpenTelemetry.Exporter.Prometheus.AspNetCore/OpenTelemetry.Exporter.Prometheus.AspNetCore.csproj
(nuget)src/OpenTelemetry.Exporter.Prometheus.HttpListener/OpenTelemetry.Exporter.Prometheus.HttpListener.csproj
(nuget)src/OpenTelemetry.Extensions.Hosting/OpenTelemetry.Extensions.Hosting.csproj
(nuget)src/OpenTelemetry.Shims.OpenTracing/OpenTelemetry.Shims.OpenTracing.csproj
(nuget)src/OpenTelemetry/OpenTelemetry.csproj
(nuget)test/Benchmarks/Benchmarks.csproj
(nuget)test/Directory.Build.targets
(nuget)test/OpenTelemetry.Api.ProviderBuilderExtensions.Tests/OpenTelemetry.Api.ProviderBuilderExtensions.Tests.csproj
(nuget)test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.csproj
(nuget)test/OpenTelemetry.Exporter.Prometheus.AspNetCore.Tests/OpenTelemetry.Exporter.Prometheus.AspNetCore.Tests.csproj
(nuget)test/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests.csproj
(nuget)test/OpenTelemetry.Exporter.Zipkin.Tests/OpenTelemetry.Exporter.Zipkin.Tests.csproj
(nuget)test/OpenTelemetry.Extensions.Hosting.Tests/OpenTelemetry.Extensions.Hosting.Tests.csproj
(nuget)test/OpenTelemetry.Instrumentation.W3cTraceContext.Tests/OpenTelemetry.Instrumentation.W3cTraceContext.Tests.csproj
(nuget)test/OpenTelemetry.Shims.OpenTracing.Tests/OpenTelemetry.Shims.OpenTracing.Tests.csproj
(nuget)test/OpenTelemetry.Tests.Stress/OpenTelemetry.Tests.Stress.csproj
(nuget)test/OpenTelemetry.Tests/OpenTelemetry.Tests.csproj
(nuget)test/TestApp.AspNetCore/TestApp.AspNetCore.csproj
(nuget)Configuration Summary
Based on the default config's presets, Renovate will:
fix
for dependencies andchore
for all others if semantic commits are in use.node_modules
,bower_components
,vendor
and various test/tests (except for nuget) directories.github-action
digests._VERSION
variables in Dockerfiles._VERSION
environment variables in GitHub Action files.Signed-off-by:
to signoff Git commits.🔡 Do you want to change how Renovate upgrades your dependencies? Add your custom config to
renovate.json
in this branch. Renovate will update the Pull Request description the next time it runs.What to Expect
With your current configuration, Renovate will create 16 Pull Requests:
Bump codecov/codecov-action action to v5.5.1
renovate/github-actions/codecov-codecov-action-5.x
main
5a1091511ad55cbe89839c7260b706298ca349f7
Bump dotnet monorepo
renovate/nuget/dotnet-monorepo
main
8.0.19
9.0.8
9.0.8
9.0.8
9.0.8
9.0.8
9.0.8
9.0.8
9.0.8
9.0.8
9.8.0
9.0.8
8.0.6
Bump dependency Google.Protobuf to 3.32.0
renovate/nuget/protobuf-monorepo
main
3.32.0
Bump dependency Grpc to 2.46.6
renovate/nuget/grpc-2.x
main
2.46.6
Bump dependency Grpc.Tools to 2.72.0
renovate/nuget/grpc.tools-2.x
main
2.72.0
Bump dependency Microsoft.NET.Test.Sdk to 17.14.1
renovate/nuget/vstest-monorepo
main
17.14.1
Bump dependency NuGet.Versioning to 6.14.0
renovate/nuget/nuget-monorepo
main
6.14.0
Bump dependency Swashbuckle.AspNetCore to 6.9.0
renovate/nuget/swashbuckle-aspnetcore-monorepo
main
6.9.0
Bump grpc-dotnet monorepo to 2.71.0
renovate/nuget/grpc-dotnet-monorepo
main
2.71.0
2.71.0
2.71.0
Bump opentelemetry-dotnet-contrib monorepo to 1.12.0
renovate/nuget/opentelemetry-dotnet-contrib-monorepo
main
1.12.0
1.12.0
1.12.0
Bump actions/setup-dotnet action to v5
renovate/github-actions/actions-setup-dotnet-5.x
main
d4c94342e560b34958eacfc5d055d21461ed1c5d
Bump actions/stale action to v10
renovate/github-actions/actions-stale-10.x
main
3a9db7e6a41a89f618792c92c0e97cc736e1b13f
Bump dependency MinVer to v6
renovate/nuget/minver-6.x
main
6.0.0
Bump dependency RabbitMQ.Client to v7
renovate/nuget/rabbitmq.client-7.x
main
7.1.2
Bump dependency Swashbuckle.AspNetCore to v9
renovate/nuget/major-swashbuckle-aspnetcore-monorepo
main
9.0.4
Bump dependency ubuntu to v24
renovate/github-actions/ubuntu-24.x
main
24.04
❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.
This PR was generated by Mend Renovate. View the repository job log.