Skip to content

Conversation

grcevski
Copy link
Contributor

This PR adds a timeout around the call to harvest routes from executables/processes. We can have a zombie process or a process that's struggling to respond, we shouldn't permanently block the pipeline when this happens. I set the default timeout to be 10 seconds.

@grcevski grcevski requested a review from a team as a code owner September 15, 2025 19:52
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 72.34043% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.50%. Comparing base (4cb0ee0) to head (6117236).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kg/components/transform/route/harvest/harvester.go 71.73% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
- Coverage   61.56%   61.50%   -0.07%     
==========================================
  Files         199      199              
  Lines       22045    22086      +41     
==========================================
+ Hits        13572    13583      +11     
- Misses       7506     7531      +25     
- Partials      967      972       +5     
Flag Coverage Δ
integration-test-arm 34.55% <57.44%> (+0.06%) ⬆️
k8s-integration-test-1856- ?
k8s-integration-test-1858- 50.06% <57.44%> (?)
oats-test 37.14% <72.34%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@grcevski grcevski merged commit b523ed4 into open-telemetry:main Sep 16, 2025
19 checks passed
@grcevski grcevski deleted the route_harvester_timeout branch September 16, 2025 21:45
carsontham pushed a commit to carsontham/opentelemetry-ebpf-instrumentation that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants