Skip to content

Conversation

carsontham
Copy link
Contributor

Removed reference to Collector's batch processor.
Fixes #583

@carsontham carsontham requested a review from a team as a code owner September 16, 2025 17:21
@grcevski
Copy link
Contributor

Thanks for doing this @carsontham! I've kicked off the tests. We are experiencing an issue with the Kubernetes integration tests, but hopefully that should get resolved soon, there's a PR inbound.

@MrAlias
Copy link
Contributor

MrAlias commented Sep 17, 2025

@carsontham are you able to look into the test failures?

@carsontham carsontham force-pushed the remove-collector-batch-processor-ref branch from 359f0ab to aa0671c Compare September 19, 2025 08:32
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.65%. Comparing base (6d8d1a0) to head (11e708c).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   61.67%   61.65%   -0.03%     
==========================================
  Files         199      199              
  Lines       22124    22128       +4     
==========================================
- Hits        13645    13642       -3     
- Misses       7510     7519       +9     
+ Partials      969      967       -2     
Flag Coverage Δ
integration-test-arm 34.45% <ø> (-0.02%) ⬇️
k8s-integration-test-1935- ?
k8s-integration-test-1973- 50.09% <ø> (?)
oats-test 37.17% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@carsontham carsontham force-pushed the remove-collector-batch-processor-ref branch from f5a585d to 11e708c Compare September 21, 2025 13:59
@carsontham
Copy link
Contributor Author

carsontham commented Sep 22, 2025

hi @MrAlias , could you help to re-run the test for this PR?

i noticed the shard tests sometimes fail randomly. In my current PR - shard-1 test fails.

i also noticed similar test failing in other PRs:

wondering if this is like a flaky test issue?

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the improvement

@mariomac mariomac merged commit 8b89f8d into open-telemetry:main Sep 23, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to Collector's batch processor in opentelemetry-ebpf-instrumentation
4 participants