-
Notifications
You must be signed in to change notification settings - Fork 38
Removed reference to collector's batch processor #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed reference to collector's batch processor #632
Conversation
Thanks for doing this @carsontham! I've kicked off the tests. We are experiencing an issue with the Kubernetes integration tests, but hopefully that should get resolved soon, there's a PR inbound. |
@carsontham are you able to look into the test failures? |
359f0ab
to
aa0671c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
- Coverage 61.67% 61.65% -0.03%
==========================================
Files 199 199
Lines 22124 22128 +4
==========================================
- Hits 13645 13642 -3
- Misses 7510 7519 +9
+ Partials 969 967 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f5a585d
to
11e708c
Compare
hi @MrAlias , could you help to re-run the test for this PR? i noticed the shard tests sometimes fail randomly. In my current PR - shard-1 test fails. i also noticed similar test failing in other PRs:
wondering if this is like a flaky test issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the improvement
Removed reference to Collector's batch processor.
Fixes #583