Improve route harvesting #635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java route harvester was parsing the output from the JVM with a
scanner
which is by default limited to 64K. On larger Java applications this buffer limit may not be enough for all symbols, so instead of extending the scanner to another limit, I re-wrote the code to directly parse the output buffer.I also improved the loop that handles the partial Java routes by reducing the allocations required and I added an extra test for the edge case where the optimisation may not work:
Prior benchmark results:
New benchmark results: