-
Notifications
You must be signed in to change notification settings - Fork 38
Fix target_info tracking issues #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
- Coverage 61.61% 61.55% -0.06%
==========================================
Files 199 199
Lines 22111 22307 +196
==========================================
+ Hits 13623 13732 +109
- Misses 7521 7599 +78
- Partials 967 976 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!!
This PR resolves multiple edge cases with our tracking of target_info:
Relates to #656
These error conditions are impossible to test reliably with integration tests, so I relied heavily in this PR on unit tests, simulating delayed information.