Conditionalize sched_process_free hook (#737) #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format has changed in v6.16 so we use two hooks and choose between them at runtime, depending on kernel version.
florianl
reviewed
Aug 28, 2025
rogercoll
reviewed
Aug 28, 2025
florianl
reviewed
Aug 29, 2025
There was a problem hiding this comment.
Can you add a 6.16 kernel for tests to the CI?
There was a problem hiding this comment.
qemu < 9.2 has a bug and it won't boot the 6.16 kernel on ARM, I've commented that out
christos68k
force-pushed
the
ck/fix-process-free
branch
from
85ef0c3 to
58064ec
Compare
florianl
approved these changes
Aug 29, 2025
Co-authored-by: Florian Lehner <[email protected]>
fabled
reviewed
Sep 1, 2025
Comment on lines
+39
to
+44
| var prog *ebpf.Program | ||
| if _, ok := t.ebpfProgs["tracepoint__sched_process_free"]; ok { | ||
| prog = t.ebpfProgs["tracepoint__sched_process_free"] | ||
| } else { | ||
| prog = t.ebpfProgs["tracepoint__sched_process_free_old"] | ||
| } |
There was a problem hiding this comment.
Seems somewhat clumsy. Could the tracepoint name be stashed in Tracer?
Comment on lines
+554
to
+557
| sched_process_free := "tracepoint__sched_process_free" | ||
| if _, ok := coll.Programs["tracepoint__sched_process_free_old"]; ok { | ||
| sched_process_free = "tracepoint__sched_process_free_old" | ||
| } |
There was a problem hiding this comment.
This also seems somewhat clumsy. Could this function get as an argument the tracepoint name instead?
Comment on lines
+300
to
+302
| delete(coll.Programs, "tracepoint__sched_process_free_old") | ||
| } else { | ||
| delete(coll.Programs, "tracepoint__sched_process_free") |
There was a problem hiding this comment.
This determines also the tracepoint name to use. Could it be passed to loadPerfUnwinders and returned back to Tracer constructor, so the name is determined once and then used consistently?
Co-authored-by: Timo Teräs <[email protected]>
Co-authored-by: Timo Teräs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a second hook for
sched_process_freeand updatetracerto choose which hook to load/attach at runtime, depending on kernel version.TODO:
Update eBPF binariesFixes #737