Fix screenshot workflow: derive versions at runtime, fix collector URL, assert no error pages#417
Open
MeloveGupta wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
✅ Deploy Preview for otel-ecosystem-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Hi @jaydeluca , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the screenshot workflow which was silently capturing and uploading error pages due to a stale hardcoded Java version and an invalid collector detail URL.
Changes
ecosystem-explorer/scripts/take-screenshots.mjsDETAIL_VERSION = "2.25.0"- replaced withresolveLatestVersion()which readspublic/data/javaagent/versions-index.jsonat runtime and picks the entry whereis_latest: true. This prevents the script from going stale on every new release.COLLECTOR_VERSIONresolved the same way frompublic/data/collector/versions-index.json/collector/components/latest/receiver-otlpto/collector/components/${COLLECTOR_VERSION}/core-receiver-otlpreceiverassertNoError()helper that checks for error or 404 headings after each navigation and throws if found, so the script exits non-zero instead of silently uploading error pages.github/workflows/screenshots-capture.ymlVITE_FEATURE_FLAG_COLLECTOR_PAGE: "true"to the build step so the collector detail route is enabled in the production build used by the screenshot workflowBefore / After
Before:
After:
Verified By
VITE_FEATURE_FLAG_COLLECTOR_PAGE=true bun run buildnode scripts/take-screenshots.mjs- with "All screenshots completed successfully!"screenshots/desktop-detail-details.pngshows Spring WebMVC 2.27.0 detail pagescreenshots/desktop-collector-detail.pngshows OTLP Receiver detail pageType of Change
Closes #415