feat(redesign): scaffold src/v1/ router boundary (Phase 1 - Foundation PR 2b)#470
Merged
vitorvasc merged 9 commits intoMay 14, 2026
Merged
Conversation
Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
…p.tsx Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
- Add src/v1/index.ts barrel re-exporting V1App so App.tsx's
`import { V1App } from "@/v1"` resolves
- Rewrite the internal imports inside nav-bar.tsx and theme-toggle.tsx
from `@/components/...` to `@/v1/components/...` so the moved files
resolve their siblings correctly
- Update the file-header comments in nav-bar.tsx and theme-toggle.tsx
to point at the new `src/v1/styles/*.css` locations
- Add a single isEnabled("V1_REDESIGN") read in main.tsx that sets the
.v1-app class on document.documentElement before React mounts, so
body paints against v1 surface tokens from the first frame instead
of flashing legacy navy during the React mount window
- Document the carve-out in v1-routing-pivot.md (added as an explicit
pivot rule, PR 8 cleanup checklist extended from 4 to 5 items)
- Expand the foundation-audit CSS scoping section with the two
application sites for .v1-app (html via main.tsx, V1App wrapper div)
- Extend the 2026-05-13 decision-log row in NEXT-STEPS.md with the
body-bg rationale
✅ Deploy Preview for otel-ecosystem-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
PR ScreenshotsHomeLight
Dark
Instrumentation ListLight
Dark
Detail — Details tabLight
Dark
Detail — Telemetry tabLight
Dark
Detail — Configuration tabLight
Dark
Collector ListLight
Dark
Collector DetailLight
Dark
Captured from |
Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
vitorvasc
changed the title
Signed-off-by: Vitor Vasconcellos <vvasconcellos1@gmail.com>
jaydeluca
approved these changes
May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a single
V1_REDESIGNboundary read inApp.tsxthat swaps between two top-level sub-apps, each owning its own directory tree. Implements the 2026-05-12 routing pivot.Contributes to #84 and #370.
What's in this PR
ecosystem-explorer/src/v1/. Components created on previous PRs were moved into it as part of the same diff (history preserved viagit mv)src/App.test.tsxextended with a boundary-swap test that stubsimport.meta.env.VITE_FEATURE_FLAG_V1_REDESIGNto flip between branches and asserts the right chrome renders.src/v1/V1App.test.tsxcovers the v1 sub-app in isolation (navbar mounts, primary nav landmark labelled,.v1-appwrapper present).projects/84-ui-ux-design/updated to reflect the locked decisions from this PR's planning session (PR 6 stays separate, routes mirrored,isEnabled()retained at the boundary even though both branches ship in both bundles, body bg via main.tsx carve-out).Verification
bun run typecheckclean.bun run lintclean.bun run testpasses (837 tests across 85 files).bun run formatclean (Prettier on planning docs).bun run servewith no env:http://localhost:5173/renders the legacy<Header />and home page. All legacy routes navigable. No console errors..td-navbarand.v1-appabsent from the DOM.VITE_FEATURE_FLAG_V1_REDESIGN=true bun run serve: same URL renders the opentelemetry.io-style dark navbar. Body bg paints#212529(dark) /#fff(light) from the first frame. Theme-toggle dropdown switches Light / Dark / Auto and persists across reload. All canonical paths reachable. Legacy footer renders at the bottom as the placeholder.feat/84-pr2b-v1-scaffoldingships v1 reachable on the preview URL via the existingfeat/84-*pattern innetlify.toml. Production /mainstays legacy-only.