Refactor prometheus exporter to slightly improve performance#3351
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3351 +/- ##
=======================================
- Coverage 78.0% 77.9% -0.1%
=======================================
Files 164 164
Lines 11363 11323 -40
=======================================
- Hits 8865 8826 -39
+ Misses 2301 2299 -2
- Partials 197 198 +1
🚀 New features to boost your workflow:
|
1503ae0 to
6814790
Compare
Collaborator
Author
|
This is tough to rebase. I'll wait until after #3352 as well |
6814790 to
15ab000
Compare
Collaborator
Author
|
rebased now |
Aneurysm9
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3342
This removes the intermediary metricData struct for storing metrics, and instead directly constructs them and places them in the channel.
Before:
After: