Add _total suffixes to prometheus counters#3360
Merged
Merged
Conversation
dashpole
added
the
pkg:exporter:prometheus
dashpole
force-pushed
the
prom_counter_total
branch
from
546157a to
53714eb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3360 +/- ##
=======================================
- Coverage 77.9% 77.7% -0.2%
=======================================
Files 164 164
Lines 11345 11264 -81
=======================================
- Hits 8847 8763 -84
- Misses 2301 2303 +2
- Partials 197 198 +1
|
MrAlias
approved these changes
Oct 18, 2022
MadVikingGod
approved these changes
Oct 18, 2022
dashpole
force-pushed
the
prom_counter_total
branch
from
5d5b49f to
bb230cd
Compare
dashpole
requested review from
Aneurysm9,
XSAM,
dmathieu,
evantorrie,
hanyuancheung,
jmacd and
pellared
as code owners
aramase
added a commit
to aramase/secrets-store-csi-driver
that referenced
this pull request
May 9, 2023
For prometheus counters, by default they're appending _total if it's monotonic counter. Removing the total_ prefix as it's redundant in the name (xref: open-telemetry/opentelemetry-go#3360). This is a breaking change. Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
added a commit
to aramase/secrets-store-csi-driver
that referenced
this pull request
May 9, 2023
For prometheus counters, by default they're appending _total if it's monotonic counter. Removing the total_ prefix as it's redundant in the name (xref: open-telemetry/opentelemetry-go#3360). This is a breaking change. Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
added a commit
to aramase/secrets-store-csi-driver
that referenced
this pull request
May 10, 2023
For prometheus counters, by default they're appending _total if it's monotonic counter. Removing the total_ prefix as it's redundant in the name (xref: open-telemetry/opentelemetry-go#3360). This is a breaking change. Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
added a commit
to aramase/secrets-store-csi-driver
that referenced
this pull request
May 18, 2023
For prometheus counters, by default they're appending _total if it's monotonic counter. Removing the total_ prefix as it's redundant in the name (xref: open-telemetry/opentelemetry-go#3360). This is a breaking change. Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
k8s-ci-robot
pushed a commit
to kubernetes-sigs/secrets-store-csi-driver
that referenced
this pull request
May 19, 2023
* chore: update otel to v0.38.1 and update metrics Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com> * drop the total_ prefix from the metric name For prometheus counters, by default they're appending _total if it's monotonic counter. Removing the total_ prefix as it's redundant in the name (xref: open-telemetry/opentelemetry-go#3360). This is a breaking change. Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com> * chore: bump k8s deps to v1.26.4 Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com> * skip lint for atomic writer files Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com> * update histogram boundaries Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com> * collect metrics as part of CI Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com> * validate metrics as part of e2e Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com> --------- Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
mlushpenko
added a commit
to mlushpenko/secrets-store-csi-driver
that referenced
this pull request
May 5, 2026
The OpenTelemetry Prometheus exporter appends `_total` to counter instruments (see open-telemetry/opentelemetry-go#3360), so the metrics exposed at /metrics do not match the names listed in this document. - Align the metric names in the table and sample output with the names the driver actually registers in pkg/secrets-store/stats_reporter.go. - Add the `provider` tag to rotation_reconcile_total and rotation_reconcile_error_total, which the reporter already sets. - Fix the k8s secret sync histogram name (k8s_secret_duration_sec). - Note that metrics only appear on driver pods that have served a mount/unmount/rotation, which can be confusing when port-forwarding. Fixes kubernetes-sigs#1937
mlushpenko
added a commit
to mlushpenko/secrets-store-csi-driver
that referenced
this pull request
May 6, 2026
The OpenTelemetry Prometheus exporter appends `_total` to counter instruments (see open-telemetry/opentelemetry-go#3360), so the metrics exposed at /metrics do not match the names listed in this document. - Align the metric names in the table and sample output with the names the driver actually registers in pkg/secrets-store/stats_reporter.go. - Add the `provider` tag to rotation_reconcile_total and rotation_reconcile_error_total, which the reporter already sets. - Fix the k8s secret sync histogram name (k8s_secret_duration_sec). - Note that metrics only appear on driver pods that have served a mount/unmount/rotation, which can be confusing when port-forwarding. Fixes kubernetes-sigs#1937 Signed-off-by: Maksym Lushpenko <iviakciivi@gmail.com>
mlushpenko
added a commit
to mlushpenko/secrets-store-csi-driver
that referenced
this pull request
May 6, 2026
The OpenTelemetry Prometheus exporter appends `_total` to counter instruments (see open-telemetry/opentelemetry-go#3360), so the metrics exposed at /metrics do not match the names listed in this document. - Align the metric names in the table and sample output with the names the driver actually registers in pkg/secrets-store/stats_reporter.go. - Add the provider tag to rotation_reconcile_total and rotation_reconcile_error_total, which the reporter already sets. - Fix the k8s secret sync histogram name (k8s_secret_duration_sec). - Note that metrics only appear on driver pods that have served a mount/unmount/rotation, which can be confusing when port-forwarding. Refs kubernetes-sigs#1937 Signed-off-by: Maksym Lushpenko <iviakciivi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3359
Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/data-model.md#sums-1